Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable-boot-entry flag to reset-command #1888

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Dec 14, 2023

Read the disable-boot-entry flag from ELEMENTAL_RESET_DISABLE_BOOT_ENTRY environment variable

@frelon frelon requested a review from a team as a code owner December 14, 2023 14:18
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Out of curiosity, in which context you needed that? Or you just saw it was missing on the list?

@frelon
Copy link
Contributor Author

frelon commented Dec 14, 2023

LGTM

Out of curiosity, in which context you needed that? Or you just saw it was missing on the list?

I found this when trying to build an rpi image in the SeedImage where the elemental-register command passes flags using environment variables 👍

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f259ee) 73.60% compared to head (a15d4ac) 73.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1888   +/-   ##
=======================================
  Coverage   73.60%   73.61%           
=======================================
  Files          69       69           
  Lines        7332     7333    +1     
=======================================
+ Hits         5397     5398    +1     
  Misses       1544     1544           
  Partials      391      391           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon enabled auto-merge (squash) December 14, 2023 16:26
@frelon frelon merged commit 6174256 into rancher:main Dec 14, 2023
14 checks passed
@frelon frelon deleted the reset-disable-boot-entry branch February 9, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants