Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1.3.0 as upgrade base image #1910

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Jan 22, 2024

This PR changes which image is used in the upgrade tests.

@frelon frelon requested a review from a team as a code owner January 22, 2024 18:08
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (2e18efa) 73.83% compared to head (db4c9a4) 73.85%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/bootloader/grub.go 89.18% 3 Missing and 1 partial ⚠️
pkg/action/upgrade.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1910      +/-   ##
==========================================
+ Coverage   73.83%   73.85%   +0.02%     
==========================================
  Files          71       71              
  Lines        7773     7779       +6     
==========================================
+ Hits         5739     5745       +6     
- Misses       1612     1613       +1     
+ Partials      422      421       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon enabled auto-merge (rebase) January 23, 2024 09:32
Copy link
Contributor

@kkaempf kkaempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞🏻

@frelon frelon merged commit fcb3d56 into rancher:main Jan 23, 2024
14 checks passed
@frelon frelon deleted the upgrade-tests-img branch February 9, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants