Include elemental partitions in mount command #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <dcassany@suse.com>
frelon
approved these changes
Jan 25, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1918 +/- ##
==========================================
+ Coverage 73.83% 73.91% +0.07%
==========================================
Files 71 71
Lines 7759 7762 +3
==========================================
+ Hits 5729 5737 +8
+ Misses 1611 1600 -11
- Partials 419 425 +6 ☔ View full report in Codecov by Sentry. |
davidcassany
force-pushed
the
mount_elemental_partitions
branch
2 times, most recently
from
f1324c3
to
452a05c
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
mount_elemental_partitions
branch
from
452a05c
to
6ae5596
Compare
davidcassany
commented
Jan 29, 2024
| @@ -4,6 +4,8 @@ DefaultDependencies=no | |||
| After=initrd-root-fs.target | |||
| Requires=initrd-root-fs.target | |||
| Before=initrd-fs.target | |||
| ConditionKernelCommandLine=!rd.cos.disable | |||
| ConditionKernelCommandLine=!elemental.disable | |||
There was a problem hiding this comment.
on my tests, not sure why, but once got this service running and failing for live ISO, not sure why 🤷🏽♂️ In any case this doesn't hurt.
|
Confirmation run done at https://github.com/rancher/elemental/actions/runs/7691982270/job/20958173282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR essentially adds an additional step in mount command to mount elemental partitions before hand (OEM, Persistent, EFI, etc.). Elemental partitions should already mounted and prepare at initramfs stage and even before the persistent paths are set (otherwise instead of being defined in a persistent area they are on
/run's tmpfs).