Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build toolkit on nightly #1965

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Build toolkit on nightly #1965

merged 1 commit into from
Feb 21, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 20, 2024

We could also consider building the toolkit when pushing to main, but this will fix the error for now.

@frelon frelon requested a review from a team as a code owner February 20, 2024 12:33
Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f802fa) 73.10% compared to head (a629ae2) 73.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   73.10%   73.10%           
=======================================
  Files          74       74           
  Lines        8666     8666           
=======================================
  Hits         6335     6335           
  Misses       1819     1819           
  Partials      512      512           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon merged commit 67e3471 into rancher:main Feb 21, 2024
17 of 19 checks passed
@frelon frelon deleted the nightly-tests branch February 21, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants