bump elemental-toolkit to v2 #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
bump_to_v2
branch
from
6fa96e2
to
df28c1f
Compare
frelon
reviewed
Feb 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1969 +/- ##
=======================================
Coverage 72.53% 72.53%
=======================================
Files 76 76
Lines 8909 8909
=======================================
Hits 6462 6462
Misses 1913 1913
Partials 534 534 ☔ View full report in Codecov by Sentry. |
davidcassany
force-pushed
the
bump_to_v2
branch
from
ad6fe12
to
edf8bbe
Compare
davidcassany
commented
Feb 22, 2024
| v1 "github.com/rancher/elemental-toolkit/pkg/types/v1" | ||
| "github.com/rancher/elemental-toolkit/v2/pkg/constants" | ||
| eleError "github.com/rancher/elemental-toolkit/v2/pkg/error" | ||
| "github.com/rancher/elemental-toolkit/v2/pkg/types" |
There was a problem hiding this comment.
@frelon if I understood what you meant you were imagining something like that right? So no v1 or v2, only types which somehow also reflects we are not supporting both on the same code base.
There was a problem hiding this comment.
Yep, otherwise we could consider keeping the pkg/types/v1 directory and only making changes in v2, but it feels like overkill to me 👍
frelon
approved these changes
Feb 22, 2024
davidcassany
force-pushed
the
bump_to_v2
branch
2 times, most recently
from
f6171e8
to
c71a5c8
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
This commit leaves the code with a single set of types and in refers to it as the types packge instead of v1 or v2. For the time being we do not foresee managing more than one single major version of type within the same code. Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1927