Keep previous behavior for persistent binded paths #1984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch the current (stable release) behavior of binded persistent paths is kept.
This commit adds a new rsync wrapper method (
MirrorData
) which includes the--delete
flag. Named mirror because it actually causes the target and source to have the same exact data causing the deletion of any file already present in target that is not present in source. This is the behavior we want when dumping the image root-tree to a new snapshot.Current behavior updates at early boot all files in a given path from the image to the persisted path. This includes a couple of non obvious behaviors:
Fixes #1982