Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align sysroot mount options with SLE Micro, which in turn is applying… #1998

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented Mar 7, 2024

Align sysroot mount options with SLE Micro, which in turn is applying default mount options

@davidcassany davidcassany requested a review from a team as a code owner March 7, 2024 13:50
@davidcassany
Copy link
Contributor Author

As of today the current default images for SLE Micro I could found they mount root and snapshots with

UUID=cf1b3a39-54c1-4f32-a370-b225e1dcc1c2 / btrfs ro 0 0
UUID=cf1b3a39-54c1-4f32-a370-b225e1dcc1c2 /.snapshots btrfs defaults,subvol=@/.snapshots 0 0

from /etc/fstab. This is also great as relies on system default rather than a static list of mount options.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.53%. Comparing base (334f4ee) to head (9c3f0d1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1998   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files          76       76           
  Lines        8910     8910           
=======================================
  Hits         6463     6463           
  Misses       1913     1913           
  Partials      534      534           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… default mount options

Signed-off-by: David Cassany <dcassany@suse.com>
@davidcassany davidcassany force-pushed the align_default_mount_options_with_sle_micro branch from dca2b70 to 9c3f0d1 Compare March 7, 2024 13:58
@davidcassany davidcassany merged commit 744e9fd into rancher:main Mar 7, 2024
16 of 19 checks passed
@davidcassany davidcassany deleted the align_default_mount_options_with_sle_micro branch March 7, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants