Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable boot entry if efivars is read-only #2059

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Apr 24, 2024

On some systems the efivars is mounted read-only if the firmware does not support writing (such as RPI).

This commit turns off writing boot entries to efivars if the efivars filesystem is mounted read-only.

@frelon frelon requested a review from a team as a code owner April 24, 2024 13:04
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

On some systems the efivars is mounted read-only if the firmware does
not support writing (such as RPI).

This commit turns off writing boot entries to efivars if the efivars
filesystem is mounted read-only.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon enabled auto-merge (squash) April 24, 2024 13:48
@frelon frelon merged commit 8baaef2 into rancher:main Apr 24, 2024
17 checks passed
@frelon frelon deleted the ro-efivars branch April 24, 2024 14:07
davidcassany pushed a commit to davidcassany/elemental-toolkit that referenced this pull request Jul 18, 2024
On some systems the efivars is mounted read-only if the firmware does
not support writing (such as RPI).

This commit turns off writing boot entries to efivars if the efivars
filesystem is mounted read-only.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
(cherry picked from commit 8baaef2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants