Refine relabel step #2078
Merged
Refine relabel step #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
commented
May 13, 2024
| @@ -420,6 +421,13 @@ func SelinuxRelabel(cfg *types.RunConfig, spec *types.MountSpec) error { | |||
|
|
|||
| paths := []string{} | |||
| paths = append(paths, spec.Ephemeral.Paths...) | |||
| for _, vol := range append(spec.Volumes, &spec.Persistent.Volume) { | |||
There was a problem hiding this comment.
This is to also relabel /oem and other eventual volumes mounted as RW.
There was a problem hiding this comment.
Nice, I was thinking of this, but would it not impact the persistent volume as well?
There was a problem hiding this comment.
Well, the idea is to also relabel the persistent volume. The only case in which is not relabeled is when this is mounted under /run. I have not fully tested it yet, but I'd like to be capable to set the persistent volume mountpoint to /var, in that case we should also relabel /var.
To be honest to it looks like we might need to revisit this part as long as we gain experience and encounter new corner cases. It is hard to generalize.
frelon
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.