Bump mount utils #2099
Bump mount utils #2099
Conversation
|
Huh ? This seems to bump much more than just the mount utils ?! |
davidcassany
force-pushed
the
bump_mount-utils
branch
from
c38b002
to
abba400
Compare
| @@ -28,7 +28,7 @@ type Mounter interface { | |||
| } | |||
|
|
|||
| func NewMounter(binary string) Mounter { | |||
| return mount.New(binary) | |||
| return mount.NewWithoutSystemd(binary) | |||
There was a problem hiding this comment.
This is a new method provided with the updated interface which provides a mount wrapper that does not pretend to detect systemd. For instance this has impact on make test-cli target being executed in a desktop env. In that case every time a new mounter got initiated a systemd dialog appeared to provide the root password interactively, even it we are not mounting anything in our unit tests and they all can run as a non root user.
func mount.NewWithoutSystemd(mounterPath string) mount.Interface
NewWithoutSystemd returns a Linux specific mount.Interface for the current system.
It provides options to override the default mounter behavior. mounterPath allows
using an alternative to `/bin/mount` for mounting. Any detection for systemd functionality
is disabled with this Mounter.
A part from that we were already a bit outdated in that library.
| @@ -25,7 +27,7 @@ require ( | |||
| github.com/spf13/viper v1.15.0 | |||
| golang.org/x/crypto v0.21.0 | |||
| gopkg.in/yaml.v3 v3.0.1 | |||
| k8s.io/mount-utils v0.23.0 | |||
| k8s.io/mount-utils v0.30.1 | |||
There was a problem hiding this comment.
This is the actual bump, all other changes in go.mod and in vendor are caused by the indirect dependencies and the mount-utils code itself.
There was a problem hiding this comment.
This is the actual bump, all other changes in go.mod and in vendor are caused by the indirect dependencies and the mount-utils code itself.
golang vendoring... 😅
davidcassany
force-pushed
the
bump_mount-utils
branch
from
abba400
to
3a8bcad
Compare
Signed-off-by: David Cassany <dcassany@suse.com>
Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
bump_mount-utils
branch
from
3a8bcad
to
48e4a94
Compare
| @@ -25,7 +27,7 @@ require ( | |||
| github.com/spf13/viper v1.15.0 | |||
| golang.org/x/crypto v0.21.0 | |||
| gopkg.in/yaml.v3 v3.0.1 | |||
| k8s.io/mount-utils v0.23.0 | |||
| k8s.io/mount-utils v0.30.1 | |||
There was a problem hiding this comment.
This is the actual bump, all other changes in go.mod and in vendor are caused by the indirect dependencies and the mount-utils code itself.
golang vendoring... 😅
Co-authored-by: Francesco Giudici <francesco.giudici@gmail.com> Signed-off-by: David Cassany Viladomat <dcassany@suse.com>
No description provided.