Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure pulling user-data from CDROM #2

Closed
mudler opened this issue Jan 27, 2022 · 6 comments
Closed

Failure pulling user-data from CDROM #2

mudler opened this issue Jan 27, 2022 · 6 comments
Labels
area/elemental status/blocked Issue depend on another one

Comments

@mudler
Copy link
Contributor

mudler commented Jan 27, 2022

Latest builds from CI fails tests cause of this:

INFO[0000] Processing stage step 'Pull data from provider (local)'  commands=0 delete_entities=0 entities=0 files=0 nameserver=0 step="Pull data from provider (local)"
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/diskfs/go-diskfs/filesystem/iso9660.parseDirEntry({0x10ab068, 0x10ab068, 0xa}, 0xc000206038)
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/directoryentry.go:281 +0x56f
github.com/diskfs/go-diskfs/filesystem/iso9660.Read({0xc3f900, 0xc00000f138}, 0x5b000, 0x0, 0xc0002062d8)
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/iso9660.go:223 +0x9fa
github.com/diskfs/go-diskfs/disk.(*Disk).GetFilesystem(0xc00007d5e0, 0x0)
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/diskfs/go-diskfs/disk/disk.go:227 +0x238
github.com/davidcassany/linuxkit/pkg/metadata/providers.FindCIs()
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/davidcassany/linuxkit/pkg/metadata/providers/provider_cdrom.go:85 +0x3a6
github.com/davidcassany/linuxkit/pkg/metadata/providers.ListCDROMs()
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/davidcassany/linuxkit/pkg/metadata/providers/provider_cdrom.go:45 +0xae
github.com/mudler/yip/pkg/plugins.DataSources({{0x0, 0x0, 0x0}, {0x0, 0x0, 0x0}, {0x0, 0x0, 0x0}, {0x0, ...}, ...}, ...)
        /luetbuild/go/src/github.com/mudler/yip/pkg/plugins/datasource.go:49 +0xb4b
github.com/mudler/yip/pkg/executor.(*DefaultExecutor).Apply(0xc00023f400, {0x7fff88984ac2, 0x7}, {{0xc0002a2ec0, 0x1}, 0xc00024f4a0}, {0xc56f28, 0x10aad40}, {0xc3fc90, 0x10ab068})
        /luetbuild/go/src/github.com/mudler/yip/pkg/executor/default.go:162 +0xcd9
github.com/mudler/yip/pkg/executor.(*DefaultExecutor).run(0x20, {0x7fff88984ac2, 0x7}, {0xc0002a2de0, 0x1e}, {0xc56f28, 0x10aad40}, {0xc3fc90, 0x10ab068}, 0xb80300, ...)
        /luetbuild/go/src/github.com/mudler/yip/pkg/executor/default.go:92 +0x13a
github.com/mudler/yip/pkg/executor.(*DefaultExecutor).walkDir.func1({0xc0002a2de0, 0x0}, {0xc49240, 0xc0002a6340}, {0x0, 0x0})
        /luetbuild/go/src/github.com/mudler/yip/pkg/executor/default.go:72 +0x20b
github.com/twpayne/go-vfs.walk({0x7fe455ad6818, 0x10aad40}, {0xc0002a2de0, 0x1e}, 0xc000207bb0, {0xc49240, 0xc0002a6340}, {0x0, 0x0})
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/twpayne/go-vfs/walk.go:30 +0xbb
github.com/twpayne/go-vfs.walk({0x7fe455ad6818, 0x10aad40}, {0x7fff88984aca, 0xb}, 0xc000207bb0, {0xc49240, 0xc000271ba0}, {0x0, 0x0})
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/twpayne/go-vfs/walk.go:47 +0x2e5
github.com/twpayne/go-vfs.Walk({0x7fe455ad6818, 0x10aad40}, {0x7fff88984aca, 0xb}, 0x7fff88984aca)
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/twpayne/go-vfs/walk.go:58 +0x66
github.com/mudler/yip/pkg/executor.(*DefaultExecutor).walkDir(0x10aad40, {0x7fff88984ac2, 0x7fe455ac3370}, {0x7fff88984aca, 0xb}, {0xc56f28, 0x10aad40}, {0xc3fc90, 0x10ab068})
        /luetbuild/go/src/github.com/mudler/yip/pkg/executor/default.go:55 +0x10e
github.com/mudler/yip/pkg/executor.(*DefaultExecutor).runStage(0xc00023f400, {0x7fff88984ac2, 0x7}, {0x7fff88984aca, 0xb}, {0xc56f28, 0x10aad40}, {0xc3fc90, 0x10ab068})
        /luetbuild/go/src/github.com/mudler/yip/pkg/executor/default.go:104 +0x21c
github.com/mudler/yip/pkg/executor.(*DefaultExecutor).Run(0xe, {0x7fff88984ac2, 0x7}, {0xc56f28, 0x10aad40}, {0xc3fc90, 0x10ab068}, {0xc00024ec60, 0x1, 0x3})
        /luetbuild/go/src/github.com/mudler/yip/pkg/executor/default.go:122 +0x147
github.com/mudler/yip/cmd.glob..func1(0x10709a0, {0xc00024ec60, 0x1, 0x3})
        /luetbuild/go/src/github.com/mudler/yip/cmd/root.go:107 +0x2a8
github.com/spf13/cobra.(*Command).execute(0x10709a0, {0xc000030090, 0x3, 0x3})
        /luetbuild/go/src/github.com/mudler/yip/vendor/github.com/spf13/cobra/command.go:860 +0x5f8

See also: diskfs/go-diskfs#103
@mudler mudler changed the title Failure pulling user-data Failure pulling user-data from CDROM Jan 27, 2022
mudler added a commit that referenced this issue Jan 27, 2022
@mudler
Remove -rock when creating user-data ISO
8daf1ef 
Workaround for #2
@mudler
Copy link
Contributor Author

mudler commented Jan 27, 2022

https://github.com/davidcassany/linuxkit/pull/3
https://github.com/davidcassany/linuxkit/pull/4

@mudler mudler self-assigned this Jan 27, 2022
@mudler mudler mentioned this issue Jan 27, 2022
Closed
mudler added a commit that referenced this issue Jan 27, 2022
@mudler
Remove -rock when creating user-data ISO
75c4176 
Workaround for #2
mudler added a commit that referenced this issue Jan 27, 2022
@mudler
Remove -rock when creating user-data ISO
e3f22d9 
Workaround for #2
@mudler
Copy link
Contributor Author

mudler commented Jan 27, 2022 •
edited
Loading

Needs an updated version of yip/elemental with a bump of go-diskfs

@mudler
Copy link
Contributor Author

mudler commented Jan 27, 2022

A new yip version has been tagged with the submodules bump (go-diskfs, linuxkit with the above patches): mudler/yip@0.10.0...0.10.1

@mudler
Copy link
Contributor Author

mudler commented Jan 27, 2022

Current workaround for CI is to drop the -rock flag: 8daf1ef

@mudler mudler mentioned this issue Jan 28, 2022
Closed
mudler added a commit that referenced this issue Jan 28, 2022
@mudler
Remove -rock when creating user-data ISO
2f3897e 
Workaround for #2

Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler
Copy link
Contributor Author

mudler commented Jan 28, 2022

Blocked by rancher/elemental-toolkit#1104

@mudler mudler added the status/blocked Issue depend on another one label Jan 28, 2022
@mudler mudler removed their assignment Jan 28, 2022
@mudler
Copy link
Contributor Author

mudler commented Jan 28, 2022 •
edited
Loading

Depends on #63 and a new version of the cli available in cos repos

mudler added a commit that referenced this issue Jan 31, 2022
@mudler
test: Re add rockridge iso support
b71299f 
Fixes: #2
mudler added a commit that referenced this issue Jan 31, 2022
@mudler
test: Re add rockridge iso support
436e644 
Fixes: #2
Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
@mudler mudler mentioned this issue Feb 1, 2022
Closed
@mudler mudler closed this as completed in 8cca5a1 Feb 1, 2022
mudler pushed a commit that referenced this issue Jun 3, 2022
Merge pull request #2 from Itxaka/installer
f7339de
ldevulder added a commit that referenced this issue Oct 3, 2022
@ldevulder
ci/e2e+ui: set condition to start the runner #2
a9fe03d 
Try to really fix it this time...

Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder added a commit that referenced this issue Oct 3, 2022
@ldevulder
ci/e2e+ui: set condition to start the runner #2
ee213fb 
Try to really fix it this time...

Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder added a commit that referenced this issue Oct 3, 2022
@ldevulder
ci/e2e+ui: set condition to start the runner #2
8c571a3 
3rd try...

Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder added a commit that referenced this issue Oct 3, 2022
@ldevulder
ci/e2e+ui: set condition to start the runner #2
f573950 
3rd try...

Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder added a commit that referenced this issue Jan 3, 2023
@ldevulder
ci/ui: fix permissions for 'downloads' directory #2
c2f6f60 
It was missing for `Store logs` step.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
ldevulder added a commit that referenced this issue Jan 3, 2023
@ldevulder
ci/ui: fix permissions for 'downloads' directory #2
90e47a0 
It was missing for `Store logs` step.

Signed-off-by: Loic Devulder <ldevulder@suse.com>
juadk added a commit that referenced this issue Jan 19, 2024
@juadk
Address review comments #2
df6e08e
juadk added a commit that referenced this issue Jan 19, 2024
@juadk
Address review comments #2
318ad62
juadk added a commit that referenced this issue Jan 19, 2024
@juadk
Address review comments #2
ac9d439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/elemental status/blocked Issue depend on another one
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mudler