Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag with %VERSION% #1063

Merged
merged 1 commit into from Oct 26, 2023
Merged

tag with %VERSION% #1063

merged 1 commit into from Oct 26, 2023

Conversation

kkaempf
Copy link
Contributor

@kkaempf kkaempf commented Oct 26, 2023

#!BuildTag was wrong, must tag as VERSION not as RELEASE

@kkaempf
tag with %VERSION%
8ea9f7b 
Signed-off-by: Klaus Kämpf <kkaempf@suse.de>
@kkaempf kkaempf requested a review from a team as a code owner October 26, 2023 13:29
davidcassany
davidcassany approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit 3acfc10 into rancher:main Oct 26, 2023
7 of 9 checks passed
@kkaempf kkaempf deleted the fix-flavored-tag branch December 29, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcassany davidcassany davidcassany approved these changes

@frelon frelon frelon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Elemental
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kkaempf @davidcassany @frelon