Consume go-tpm in place of tpm in rancherd/os2 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #20. Will allow later on to set an emulated device. Signed-off-by: Ettore Di Giacinto <edigiacinto@suse.com>
mudler
commented
Feb 17, 2022
| github.com/rancher/fleet/pkg/apis v0.0.0-20210927195558-4aaa778d23dd | ||
| github.com/rancher/lasso v0.0.0-20210709145333-6c6cd7fd6607 | ||
| github.com/rancher/rancher/pkg/apis v0.0.0-20211013185633-a636bda2a00e | ||
| github.com/rancher/rancherd v0.0.1-alpha9.0.20211028172625-bdf5642d62d5 |
There was a problem hiding this comment.
and this unties us from rancherd. I would actually vote to have rancherd using go-tpm as it encompasses the general usage done in both cases.
Itxaka
approved these changes
Feb 17, 2022
yep without a bit of exploring how tpm work is hard to grasp at hand, but this is mostly refactoring and adding options around so can be re-used and tested. The emulation part is the real "new" addition, which is used in the unit tests |
|
yup, I already had a look yesterday to the branch...could not understand much :P but looked kind of straighforward |
mudler
pushed a commit
that referenced
this pull request
Jun 3, 2022
* Make a CloudInitRunner interface Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20. Will allow later on to set an emulated device.
Those are the changeset on top of
tpmthat was provided on rancherd: rancher-sandbox/go-tpm@c2203f4...main , in summary:Signed-off-by: Ettore Di Giacinto edigiacinto@suse.com