Add clusterGroup test automation #155
Conversation
sbulage
force-pushed
the
automate-clustergroup-test
branch
8 times, most recently
from
29c85af
to
e1dd359
Compare
|
2.9 CI Run Link: |
sbulage
force-pushed
the
automate-clustergroup-test
branch
2 times, most recently
from
b811030
to
da1635f
Compare
sbulage
force-pushed
the
automate-clustergroup-test
branch
from
da1635f
to
26cac3e
Compare
|
|
||
| describe('Test application deployment based on clusterGroup', { tags: '@p1'}, () => { | ||
| qase(25, | ||
| it("Fleet-25: Test install single application to the all available clusters using 'clusterGroup'", { tags: '@fleet-25' }, () => { |
There was a problem hiding this comment.
Q: is it really installing in ALL available clusters or in all defined clusters?
There was a problem hiding this comment.
It is installing to all available cluster present in cluster group.
There was a problem hiding this comment.
Updated it. Please take a look at it.
There was a problem hiding this comment.
Sorry, not sure I see the change
There was a problem hiding this comment.
See this:
qase(25, it("Fleet-25: Test install single application to the all available clusters in the 'clusterGroup'", { tags: '@fleet-25' }, () => {
There was a problem hiding this comment.
ok, the part all available clusters is the one I still found confusing. Given that you provided a list of clusters (const dsClusterList = ["imported-0", "imported-1"]) I thought it was going to be changed to something like all defined clusters. or all specified clusters.
Again, not mandatory. PR is already approved.
sbulage
force-pushed
the
automate-clustergroup-test
branch
3 times, most recently
from
c2a0fa7
to
a4cbd10
Compare
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
sbulage
force-pushed
the
automate-clustergroup-test
branch
2 times, most recently
from
e320510
to
21fddcc
Compare
Signed-off-by: Satyajit Bulage <satyajit.bulage@suse.com>
sbulage
force-pushed
the
automate-clustergroup-test
branch
from
21fddcc
to
21723f2
Compare
|
2.8 PR check failed with other test which are unrelated to this PR change. I re-ran but it was queued for so long, hence I canceled it. Later, I initiate another CI run on 2.8: https://github.com/rancher/fleet-e2e/actions/runs/9860812197/job/27229140011 |
| dsClusterList.forEach( | ||
| (dsClusterName) => { | ||
| // Adding wait to load page correctly to avoid interference with hamburger-menu. | ||
| cy.wait(500); |
There was a problem hiding this comment.
Did we tried as commented checking a landing locator rather than waits?
Not mandatory removal, just suggestion.
There was a problem hiding this comment.
We didn't find the landing locator after navigating to hamburgermenu...
There was a problem hiding this comment.
Not in the a few mins meeting, but thought it was going to be looked deeper with more time later
There was a problem hiding this comment.
I approved pr. I leave opt to you to try or merge as it is.
|
Separate run based on this PR's branch: 🟢 Passed --> https://github.com/rancher/fleet-e2e/actions/runs/9887523547/job/27312031567 |
Fixes: #154