Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Labels and Annotations #1133

Closed
3 tasks done
manno opened this issue Nov 29, 2022 · 2 comments · Fixed by #1310
Closed
3 tasks done

Clean up Labels and Annotations #1133

manno opened this issue Nov 29, 2022 · 2 comments · Fixed by #1310
Assignees

Comments

@manno
Copy link
Member

manno commented Nov 29, 2022

  • Annotation fleet.cattle.io/managed appears unused, label of the same name is in use
  • Label fleet.cattle.io/bootstrap-token is unused
  • Annotations fleet.cattle.io/cluster, fleet.cattle.io/cluster-namespace are never used on a Cluster resource
@manno
Copy link
Member Author

manno commented Jan 11, 2023

@thardeck
Copy link
Contributor

thardeck commented Feb 7, 2023

As described in the documentation mentioned above the annotations fleet.cattle.io/cluster and fleet.cattle.io/cluster-namespace are used on a cluster namespace to reference the cluster registration namespace and to check if the namespace can be cleaned up.
The code reflects the documentation so the two annotations need to stay.

e.g.:

clusterNS := ns.Annotations[fleet.ClusterNamespaceAnnotation]
clusterName := ns.Annotations[fleet.ClusterAnnotation]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants