Clean up orphaned request service accounts, remove unused managed annotations #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The label with the same path is actually used and kept.
manno
requested changes
Feb 7, 2023
thardeck
force-pushed
the
clean_up_label_and_annotations
branch
from
8238c58
to
4374560
Compare
otherwise these resources will not get purged when there is no managed label equals true.
thardeck
force-pushed
the
clean_up_label_and_annotations
branch
from
4374560
to
4bc7b95
Compare
manno
reviewed
Feb 7, 2023
for the namespace object.
manno
approved these changes
Feb 8, 2023
manno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1133
I have also checked rancher/rancher and rancher/ui for usage of the supposedly obsolete annotations and labels.