Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BundleNamespaceMapping ignoring bundle selector #1425

Merged
merged 3 commits into from Mar 22, 2023
Merged

Fix BundleNamespaceMapping ignoring bundle selector #1425

merged 3 commits into from Mar 22, 2023

Conversation

manno
Copy link
Member

@manno manno commented Mar 20, 2023 •
edited by zube bot

Adds test for #1401 and cherry picks the fix.

We noticed that the custom resource ignores the configured bundle selector. If you create a BundleNamespaceMapping all bundles in this namespace will be mapped to the downstream clusters.
We already tested this change with our custom build which you can reach here: johnjcool/fleet:0.6.0-rc.5.7

refers to issue #1427

@manno manno mentioned this pull request Mar 20, 2023
Closed
@manno manno marked this pull request as ready for review March 20, 2023 15:42
@manno manno requested a review from a team as a code owner March 20, 2023 15:42
@manno manno merged commit 8434f8e into master Mar 22, 2023
@manno manno deleted the fix-bnm-selector branch March 22, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcabello raulcabello raulcabello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manno @raulcabello @johnjcool