Always get labels from Bundle when creating a BundleDeployment #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleDeployment labels were not being updated when changed in the fleet.yaml Always get the labels from the Bundle when creating a BundleDeployment Signed-off-by: raul <raul.cabello@suse.com>
raulcabello
force-pushed
the
bundledeployment-labels
branch
from
c56e715
to
de6c112
Compare
Add a test case to cover the scenario where a Bundle label is changed, and this changed is applied to the relevant BundleDeployment. Signed-off-by: raul <raul.cabello@suse.com>
It is not needed as we always use wrangler controllers to create or update resources (such as BundleDeployments) This was causing wrangler to use application/strategic-merge-patch+json when doing a patch, and this was causing the patch to fail. Signed-off-by: raul <raul.cabello@suse.com>
raulcabello
force-pushed
the
bundledeployment-labels
branch
from
de6c112
to
db34da7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a label is modified in the
fleet.yamlis also modified in theBundle, but no in theBundleDeploymentBundleDeploymentlabels are not being updated when changed in thefleet.yaml. This is because we just get the labels from theBundlethe first time theBundleDeploymentis created, this is done in the resetDeployment method.This PR always get the labels from the
Bundlewhen creating aBundleDeploymentBundleDeployment patch was failing in the integration tests because wrangler was using
application/strategic-merge-patch+jsonstrategy for the patch. Then I was getting the error:This was happening because I registered the
BundleandBundleDeploymentin the client, then wrangler was choosing this strategy here. I fixed this by not registering theBundleandBundleDeploymentin the client as they are not needed, then I did the same for theBundleDeploymentintegration tests here in order to prevent this error in the future.refers to #1153