Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore config map reference in valuesFrom list element #1431

Merged
merged 3 commits into from Mar 29, 2023
Merged

Don't ignore config map reference in valuesFrom list element #1431

merged 3 commits into from Mar 29, 2023

Conversation

manno
Copy link
Member

@manno manno commented Mar 22, 2023 •
edited

Refers to #1432

If both references are provided in a valuesFrom list element, use both.

TODO

@manno manno changed the title Support ConfigMapKeyRef and SecretKeyRef in same list element Don't ignore config map reference in valuesFrom list element Mar 22, 2023
@manno manno marked this pull request as ready for review March 22, 2023 16:24
@manno manno requested a review from a team as a code owner March 22, 2023 16:25
@manno manno mentioned this pull request Mar 23, 2023
Merged
raulcabello
raulcabello approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@raulcabello raulcabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manno manno merged commit fd11ed2 into master Mar 29, 2023
10 checks passed
@manno manno deleted the fix-values-from-ref branch March 29, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcabello raulcabello raulcabello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manno @raulcabello