Add ignore conditions for the status of deployed custom resources #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
previously approved these changes
Apr 20, 2023
weyfonk
reviewed
Apr 20, 2023
We can't control status in Custom Resources that don't belong to Fleet or Rancher. This is causing Fleet to consider bundles in error state when they shouldn't. Conditions inside ignore conditions field will be ignored when checking the Bundle state Signed-off-by: raul <raul.cabello@suse.com>
raulcabello
force-pushed
the
bundle-error-state
branch
from
4bb90a6
to
259e19e
Compare
Co-authored-by: Corentin Néau <tan.neau@suse.com> Signed-off-by: raul <raul.cabello@suse.com>
raulcabello
force-pushed
the
bundle-error-state
branch
from
259e19e
to
585f357
Compare
weyfonk
approved these changes
Apr 20, 2023
manno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't control the status in Custom Resources that don't belong to Fleet or Rancher. This is causing Fleet to consider bundles in error state when they shouldn't. See what happens with keda.
This PR adds a new field to set conditions to be ignored as suggested here. This allows users to ignore conditions that wrangler Summarize thinks are wrong, but are in an ok status. Ignore Conditions can be specified in the
Bundleor in thefleet.yamlrefers to #1386