Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.9] Backport: Replace json-based implementation of DeepCopy on GenericMap #1955

Merged
merged 1 commit into from Nov 23, 2023
Merged

[v0.9] Backport: Replace json-based implementation of DeepCopy on GenericMap #1955

merged 1 commit into from Nov 23, 2023

Conversation

aruiz14
Copy link
Contributor

@aruiz14 aruiz14 commented Nov 22, 2023

Backporting #1915
Part of #1842

@aruiz14 aruiz14 requested a review from a team as a code owner November 22, 2023 15:50
@weyfonk
Copy link
Contributor

weyfonk commented Nov 23, 2023

More changes may need to be backported for E2E tests to pass, as single-cluster test data has been updated to use more lightweight charts, in order to reduce test flakiness.
See this PR backporting such changes, and this PR for more context.

@aruiz14 aruiz14 force-pushed the generic-map-deep-copy-backport-0.9 branch from 94141a1 to 9dab624 Compare November 23, 2023 08:30
@aruiz14
Copy link
Contributor Author

aruiz14 commented Nov 23, 2023

More changes may need to be backported for E2E tests to pass, as single-cluster test data has been updated to use more lightweight charts, in order to reduce test flakiness. See this PR backporting such changes, and this PR for more context.

Thanks @weyfonk, I've added #1959 (and later #1961) to address that

@aruiz14 aruiz14 force-pushed the generic-map-deep-copy-backport-0.9 branch from 9dab624 to 3916ccf Compare November 23, 2023 11:21
@aruiz14 aruiz14 merged commit 942974d into release/v0.9 Nov 23, 2023
10 checks passed
@aruiz14 aruiz14 deleted the generic-map-deep-copy-backport-0.9 branch November 23, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyfonk weyfonk weyfonk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aruiz14 @weyfonk