[master] Keep CRDs when deleting a Bundle #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulcabello
force-pushed
the
remove-crds
branch
from
d987d7b
to
118df56
Compare
raulcabello
changed the title
raulcabello
force-pushed
the
remove-crds
branch
from
118df56
to
845d9e0
Compare
weyfonk
previously approved these changes
Dec 19, 2023
aruiz14
previously approved these changes
Dec 19, 2023
raulcabello
force-pushed
the
remove-crds
branch
from
4710aeb
to
81185cf
Compare
Just delete CRDs if deleteCRDResources is set to true in the fleet.yaml Add the helm.sh/resource-policy annotation for CRDs if deleteCRDResources is false or not set. This will prevent helm from deleting CRDs when a Bundle is deleted Signed-off-by: raul <raul.cabello@suse.com>
Signed-off-by: raul <raul.cabello@suse.com>
raulcabello
force-pushed
the
remove-crds
branch
from
81185cf
to
27282b3
Compare
weyfonk
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just delete CRDs if
deleteCRDResourcesis set to true in thefleet.yaml. Otherwise CRDs are kept in the cluster.This PR adds the
helm.sh/resource-policyannotation for CRDs ifdeleteCRDResourcesis false or not set. This will prevent helm from deleting CRDs when aBundleis deleted.Refers to #1978