[v0.9] Fixes panic when imagescan uses prereleases and * #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weyfonk
approved these changes
Feb 29, 2024
When using pre-releases in imagescan combined with ```yaml semver: range: * ``` it failed because `semver` ignores pre-releases unless they're explicitly described in the `semver.range`. For example: ```yaml semver: range: ">= 0.0.0-40" ``` works fine because it is explicitly using a pre-release. This fixes the `*` case by checking if there's any version found (lastVersion != nil) It also adds `e2e` tests for the following imagescans cases: * Deploy gitrepo with imagescan using `semver.range = ">= 0.0.0-40"` deploying image `0.0.0-40` and after that pushing image `0.0.0-50` * Same as above but for the case that whis branch fixed (using `semver.range = "*"` with pre-releases. Refers to: rancher#2096 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
0.9-2060-imagescans-prerelease
branch
from
3330410
to
82aebea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pre-releases in imagescan combined with
it failed because
semverignores pre-releases unless they're explicitly described in thesemver.range.For example:
works fine because it is explicitly using a pre-release.
This fixes the
*case by checking if there's any version found (lastVersion != nil)It also adds
e2etests for the following imagescans cases:semver.range = ">= 0.0.0-40"deploying image0.0.0-40and after that pushing image0.0.0-50semver.range = "*"with pre-releases.Refers to: #2181