Fix Existing Namespace Not Found By Label #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the label kubernetes.io/metadata.name, which is added by k8s to all namespaces, instead of the helm "name" label. The helm "name" label might be missing from pre-existing namespaces.
Was using List with a label, that's set by k8s to the name of the namespace. Only returned the first result. Testdata assumed label and namespace name could be different.
manno
force-pushed
the
fix-namespace-labels-missing
branch
from
fd95f12
to
b3981d7
Compare
manno
changed the title
weyfonk
approved these changes
Mar 4, 2024
internal/cmd/agent/controllers/bundledeployment/controller_test.go
Outdated
Show resolved
Hide resolved
…t.go Co-authored-by: Corentin Néau <tan.neau@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #2195
Filter by
kubernetes.io/metadata.namelabelUse the label
kubernetes.io/metadata.name, which is added by k8s to allnamespaces, instead of the helm "name" label. The helm "name" label
might be missing from pre-existing namespaces.
Switch
fetchNamespaceto Get instead of listWas using List with a label, that's set by k8s to the name of the
namespace. Only returned the first result.
Testdata assumed label and namespace name could be different.