Adds extra e2e test to check status display #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xavi0
force-pushed
the
2128-add-extra-e2e-test
branch
3 times, most recently
from
10cb974
to
ea8b757
Compare
manno
reviewed
Apr 2, 2024
|
|
||
| It("all deployments are ready and status shown is Ready", func() { | ||
| Eventually(func() bool { | ||
| frontendReady := checkNReplicasAreReady(k, "frontend", "2") |
There was a problem hiding this comment.
As discussed: Ideally we would be able to use less heavy deployments with smaller image sizes and no dependencies on physical volumes, etc.
There was a problem hiding this comment.
Yup, moving this to draft so it's not merged by mistake
There was a problem hiding this comment.
I've changed the test and now it's a simple k8s.gcr.io/pause container which should be less than 250kb and just by adding a init container sleeping 5 seconds I was able to recreate the issue with the affected RCs.
Related to: rancher#2128 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
0xavi0
force-pushed
the
2128-add-extra-e2e-test
branch
from
d7a45c7
to
b7cc172
Compare
manno
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an extra test that deploys a bit more complex scenario so it exercises the Watcher area and events that were filtered in PR: #2031
This test should fail from
v0.9.1-rc.2tov0.9.1-rc.6and was fixed after reverting the above PR inv0.9.2-rc.1It also introduces the following changes in CI:
bumpsgolangci-lintto the last versionadds theskip-pkg-cache: truetogolangci-lintUses typos→ see CI bumps golangci-lint and uses typos 1.19.0 #2269 and [Backport 0.9] CI: Revert typos back to master #2273v1.19.0as latest version (v1.20.1) adds false positivesRelated to: #2128