Add default TTL for jobs of 24h #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manno
changed the title
raulcabello
reviewed
Jul 21, 2023
raulcabello
approved these changes
Jul 21, 2023
raulcabello
approved these changes
Jul 21, 2023
manno
added a commit
that referenced
this pull request
Aug 10, 2023
Add propagationPolicy to delete job Deleting jobs via the API does not remove their pods. This PR adds the propagationPolicy to both delete request, the ForceUpdateGeneration one, which previously didn't work and the new one, which is used to retrigger failed jobs. * Revert "Merge pull request #272 from rancher/add-default-ttl" * Remove unused context value * Add debug logging to job controller * Remove the job cache from apply, so jobs can be recreated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gitjob now retries failed jobs, we need a mechanism to allow automatic clean up.
We can make this configurable later.
See
Relates to rancher/fleet#1387