[v1.29] Fix: Add Take Ownership #49
Conversation
|
❓ Do we want to continue using a fork? |
| @@ -195,6 +195,7 @@ func addInstallFlags(cmd *cobra.Command, f *pflag.FlagSet, client *action.Instal | |||
| f.BoolVar(&client.SubNotes, "render-subchart-notes", false, "if set, render subchart notes along with the parent") | |||
| f.StringToStringVarP(&client.Labels, "labels", "l", nil, "Labels that would be added to release metadata. Should be divided by comma.") | |||
| f.BoolVar(&client.EnableDNS, "enable-dns", false, "enable DNS lookups when rendering templates") | |||
| f.BoolVar(&client.TakeOwnership, "take-ownership", false, "take ownership will ignore the check for helm annotations and take ownership of the resources") | |||
There was a problem hiding this comment.
Why are we adding TakeOwnership ? How is this being used in rancher/rancher codebase ? What change that triggered this PR ?
There was a problem hiding this comment.
ForceAdopt was replaced with TakeOwnership, but there was no support for the tags which was removed for forceAdopt
There was a problem hiding this comment.
@krunalhinguu you also mentioned we are running into issues with rancher/shell due to missing vars, could you post the failure/behavior you saw there?
There was a problem hiding this comment.
So we are using forceAdopt reference in r/r, which is removed in 3.14.3, so after bumping new rancher/shell image that will become inaccessible during helm upgrade which is failing helm pods
There was a problem hiding this comment.
@krunalhinguu This PR makes sense to me now.
But what I don't understand is how rancher/rancher knows about --take-ownership=true flag since rancher/rancher codebase uses FroceAdopt. Which rancher/rancher branch are you running ?
There was a problem hiding this comment.
I have updated the code in r/r and part of 1.29 release
There was a problem hiding this comment.
@rohitsakala can we please get this merged soon. It is blocking work for 1.29 support.
cc: @Sahota1225 @snasovich
|
Didn't get you @recena |
|
@recena This is for rancher/rancher and rancher/shell which are still using forked tags, there are additional changes existing in the fork which we're dependent on so we have to continue using fork until we establish they're no longer needed. |
| @@ -195,6 +195,7 @@ func addInstallFlags(cmd *cobra.Command, f *pflag.FlagSet, client *action.Instal | |||
| f.BoolVar(&client.SubNotes, "render-subchart-notes", false, "if set, render subchart notes along with the parent") | |||
| f.StringToStringVarP(&client.Labels, "labels", "l", nil, "Labels that would be added to release metadata. Should be divided by comma.") | |||
| f.BoolVar(&client.EnableDNS, "enable-dns", false, "enable DNS lookups when rendering templates") | |||
| f.BoolVar(&client.TakeOwnership, "take-ownership", false, "take ownership will ignore the check for helm annotations and take ownership of the resources") | |||
There was a problem hiding this comment.
@krunalhinguu This PR makes sense to me now.
But what I don't understand is how rancher/rancher knows about --take-ownership=true flag since rancher/rancher codebase uses FroceAdopt. Which rancher/rancher branch are you running ?
Updates
take-ownershipwas missing fromcmd/install.goancmd/upgrade.go.Related