Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multiple images #254

Merged
merged 1 commit into from
Jun 7, 2022
Merged

add multiple images #254

merged 1 commit into from
Jun 7, 2022

Conversation

jiaqiluo
Copy link
Member

@jiaqiluo jiaqiluo commented Jun 4, 2022 •
edited

Pull Request Checklist

  • Change does not remove any existing Images or Tags in the images-list file
  • Change does not remove / overwrite exiting Images or Tags in Rancher DockerHub
  • If updating an existing entry, verify the SOURCE is still accurate and upstream hasn't been migrated to a new regitry or repo (if they've migrated, a new repo request to EIO is needed to comply with the SOURCE DESTINATION TAG pattern)
  • New entries are in format SOURCE DESTINATION TAG
  • New entries are added to the correct section of the list (sorted lexicographically)
  • New entries have a repo created in Rancher Dockerhub (where the image will be mirrored to)
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

Linked Issues

Additional Notes

Final Checks after the PR is merged

  • Confirm that you can pull the new images and tags from DockerHub

@jiaqiluo jiaqiluo mentioned this pull request Jun 4, 2022
Closed
9 tasks
@jiaqiluo jiaqiluo changed the title add etcd v3.5.4 and coredns 1.8.5 add multiple images Jun 4, 2022
@jiaqiluo jiaqiluo mentioned this pull request Jun 4, 2022
Closed
@jiaqiluo jiaqiluo marked this pull request as ready for review June 6, 2022 19:11
@jiaqiluo jiaqiluo requested a review from kinarashah as a code owner June 6, 2022 19:11
@jiaqiluo jiaqiluo requested a review from a team June 6, 2022 19:43
@superseb superseb self-requested a review June 7, 2022 18:24
@superseb superseb merged commit ae9cf51 into rancher:master Jun 7, 2022
@jiaqiluo jiaqiluo deleted the new-tags-for-1-24 branch June 7, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

@superseb superseb superseb approved these changes

@jakefhyde jakefhyde jakefhyde approved these changes

@kinarashah kinarashah Awaiting requested review from kinarashah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jiaqiluo @brandond @superseb @jakefhyde