-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm chart as source for retrieving images in workflow #489
Conversation
@rbrtbnfgl Is it okay to block the The result of adding it as a Helm chart can be seen here and would currently add the image |
we are using the cilium-operator image when we deploy cilium. |
@rbrtbnfgl Okay good, so having it blocked is the right way. Apparently the image exists but isn't used (https://quay.io/cilium/operator) Can you review the config if that is enough to get all the required images from the cilium Helm chart? |
We also can put the startup-script on the deny list. We removed it because it was only used on older K8s versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits/suggestions. this is a great feature though, I think it'll see a lot of use!
60e2c1a
to
cdf3767
Compare
@rbrtbnfgl Added to denylist |
cdf3767
to
f85850b
Compare
f85850b
to
09dd3a0
Compare
@garyduan @selvamt94 @fgiudici @andreas-kupries We now have the option to add the Helm chart as source so when new Helm charts are published, new images can be retrieved from the chart and a PR will be created with the new images. See README for examples since this PR has been merged. |
#437
Usage should be self explanatory from README.
It's not the cleanest solution as the initial design was to have an input for images and an input for tags and we would only add those tags to the images (so the same tags for the list of images). So for now I settled for wrapping the existing logic into a wrapper that takes a list of image + tag. This will help a lot of teams to not spend any more time on this (after initially adding the images for a first time).
This moves
cilium
images from the images and tags configuration to the new Helm configuration.I tested this with quite a few Helm charts to make sure it won't break quickly: