Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flannel interface to be specified on the command line #250

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

yoink00
Copy link
Contributor

@yoink00 yoink00 commented Mar 20, 2019

This should fix #200 and #72.

I am having issues building this on my local system to test properly as dapper keeps flaking out. I am hoping someone can review this while I try and fix dapper.

@yoink00
Copy link
Contributor Author

yoink00 commented Mar 23, 2019

I've now completed testing this. My dapper problems were caused by an out-dated version of Docker.

Test setup

2 Ubuntu VMs with a GRE tunnel configured.

Test 1

Run k3s as per the quick start instructions on k3s.io:

        sudo k3s server &
        # Kubeconfig is written to /etc/rancher/k3s/k3s.yaml
        sudo k3s kubectl get node

        # On a different node run the below. NODE_TOKEN comes from /var/lib/rancher/k3s/server/node-token
        # on your server
        sudo k3s agent --server https://192.168.1.24:6443 --token ${NODE_TOKEN}

Check agent log file to ensure that default interface is selected for flannel. Run a simple load and monitor network traffic using iftop.

Test 2

Run k3s specifying tunnel IP and flannel interface:

        sudo k3s server --node-ip 10.10.10.1 --flannel-iface gre1 &
        # Kubeconfig is written to /etc/rancher/k3s/k3s.yaml
        sudo k3s kubectl get node

        # On a different node run the below. NODE_TOKEN comes from /var/lib/rancher/k3s/server/node-token
        # on your server
        sudo k3s agent --server https://10.10.10.1:6443 --flannel-iface gre1 --node-ip 10.10.10.2 --token ${NODE_TOKEN}

Check agent log file to ensure that gre1 interface is selected for flannel. Run a simple load and monitor network traffic using iftop.

Result

Both tests behaved as I expected.

@yoink00
Copy link
Contributor Author

yoink00 commented Apr 8, 2019

Resolved conflicts

@deniseschannon
Copy link

@galal-hussein can you review this?

Copy link
Contributor

@galal-hussein galal-hussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @yoink00 can you squash your commits

@yoink00
Copy link
Contributor Author

yoink00 commented Apr 12, 2019

@galal-hussein Commits squashed. Thanks!

@ibuildthecloud ibuildthecloud merged commit 08c3d0d into k3s-io:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't specify interface/IP for controller, leading to invalid apiserver certificate
4 participants