Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] include subdirectories for auto-deploy manifests #892

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

iwilltry42
Copy link
Collaborator

@iwilltry42 iwilltry42 commented Oct 11, 2019

What

This PR makes the deploy controller scan the manifests directory recursively, i.e. also yaml files living in subdirectories will be deployed upon k3s start.

Why

In k3d, we can mount volumes into the k3s server container. To get custom manifests into the auto-deploy folder inside the k3s container, we have three options:

  1. we mount every file separately -> this should work
  2. we mount a whole directory into this path -> manifests created by k3s may overwrite what we put there and also write back to the host system (ro won't work, since k3s will fail to write and error out)
  3. we mount a whole directory into a subdirectory -> this works around the problems of (1) and (2), but only works, if the deploy controller also scans subdirectories

Fix: k3d-io/k3d#122

@erikwilson
Copy link
Contributor

Thanks @iwilltry42!

@erikwilson erikwilson merged commit 2651817 into k3s-io:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QUESTION] Auto deploying manifests?
2 participants