build and packaging updates #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anitgandhi It looks good! Can you merge two commits into one? Since the change to Alpine was originated from the first commit. |
1. Update Dockerfile.dapper to install Go 1.12, separate go gets for better image layer caching 2. replace ubuntu image with simple alpine base image 3. add linker flag -w for smaller binary 4. gitignore some generated files
|
@yasker done! |
|
Merged, thanks! @anitgandhi Since it's not a blocker issue, I will release the new version later. Is that OK? |
|
@yasker yup no problem! |
Closed
|
@yasker actually, do you think it would be possible to make a v0.0.6 with these changes? I know there's no functional changes, but it would make things a bit easier for us if we can include these changes :) If not, that's totally fine, I can build and ship it separately |
|
@anitgandhi No problem. v0.0.6 has been cut. Let me know if it works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've tested this in a Vagrant box and it seems to work fine. Since the binary was built with CGO_ENABLED=0 already there was no need for anything else at runtime. I initially tested with
FROM scratchbut that failed since/tmpdidn't exist (for logs), so I switched to just plainalpine:latest.The Docker image goes down from ~320MB (v0.0.5) to ~30MB 馃槃