This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Updating the types used for volumes,networks and more #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawmind0
reviewed
Oct 17, 2018
tool.go
Outdated
| DNSOpt []string `yaml:"dns_opt,omitempty"` | ||
| DNSSearch []string `yaml:"dns_search,omitempty"` | ||
| DrainTimeoutMs string `yaml:"drain_timeout_ms,omitempty"` | ||
| Volumes []map[string]interface{} `yaml:"volumes,omitempty"` |
There was a problem hiding this comment.
Volumes should be []string
- Volumes []map[string]interface{} `yaml:"volumes,omitempty"`
+ Volumes []string `yaml:"volumes,omitempty"`
There was a problem hiding this comment.
I tested with this docker-compose.yml construct and just using []string does not work. It will lead you to another Unmarshal error.
version: '3.2'
services:
web:
image: sdelements/lets-chat
stdin_open: true
tty: true
links:
- database:mongo
ports:
- 9890:8080/tcp
labels:
io.rancher.container.pull_image: always
io.rancher.scheduler.global: 'true'
networks:
- frontend
- backend
volumes:
- type: volume
source: mydata
target: /data
volume:
nocopy: true
- type: bind
source: ./static
target: /opt/app/static
There was a problem hiding this comment.
But this is version 3.2 of compose file. On Rancher v1.x just version 1 and 2 supported..
There was a problem hiding this comment.
ok, long syntax for 'volumes' is supported since version "2.3", will check about our compatibility and change the type
prachidamle
force-pushed
the
fix_volumes_type
branch
from
5538600
to
8f00f63
Compare
|
@rawmind0 @alena1108 can you review |
|
LGTM... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the unmarshal issue reported
#6