fix: remove empty field in the releaser configuration. #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jvanz
commented
Nov 9, 2023
jvanz
force-pushed
the
skip-empty-field
branch
2 times, most recently
from
e8eb18d
to
5798023
Compare
For some reason the configuration merge function is called with the src and dest "inverted". In other words, the dest map contains the defaults values defined as the first file in the -c command line argument of the command. As result, the merge function fails because it detects this as incompatible types to be merged. This commit fixes that by removing the slice len check. Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
jvanz
force-pushed
the
skip-empty-field
branch
from
5798023
to
cf82512
Compare
|
Instead of changing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The setup command is writing a file with the
releaser.osandreleaser.archfields as empty lists. This is causing problems in the merge of the default configuration and the configuration generated by the command. During the merge the fields from the files are considered different types causing a failure. As the generate file should be used to overwrite the default values does not make sense to write a file with a invalid field value (empty list). Therefore, this commit change the setup command to remove the mentioned field from the file when they are empty.Fix #1829