Add packer scripts for AWS China #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niusmallnan
reviewed
Mar 30, 2018
| { | ||
| "type": "amazon-ebs", | ||
| "name": "amazon-ebs-hvm", | ||
| "region": "cn-north-1", |
There was a problem hiding this comment.
Can we also support region cn-northwest-1?
niusmallnan
reviewed
Mar 30, 2018
scripts/aws-cn/README.md
Outdated
| @@ -0,0 +1,12 @@ | |||
| # Introduction to Packer Build Scripts in AWS China | |||
| --- | |||
There was a problem hiding this comment.
I recommend this directory structure:
amazon-cn/
- rancheros-cn-aws-ami-amis.json
- rancheros-cn-aws-ami-builder.json
- README.md
scripts/
- build-aws-cn
- build-aws-cn-builder-image
When we need to release these AMIs, we should set them to public, please check the set-amis-public script.
I think we might need another set-amis-public-cn scripts, because of the different region urls:
https://cn-northwest-1.console.amazonaws.cn
https://eu-west-1.console.aws.amazon.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added packer scripts for building AMI in cn-north-1 region. For more information, please read the introduction under directory
./scripts/aws-cnFor issue: rancher/os#2301