This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Remove -D when we set rancher.debug=false
#897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if util.Contains(cfg.Rancher.Docker.Args, "-D") { | ||
| cfg.Rancher.Docker.Args = util.FilterStrings(cfg.Rancher.Docker.Args, func(x string) bool { return x != "-D" }) | ||
| } | ||
| if !util.Contains(cfg.Rancher.SystemDocker.Args, "-D") { |
There was a problem hiding this comment.
@datawolf You probably want to skip ! here if you want to test if cfg.Rancher.SystemDocker.Args contains -D
|
Just one line comment above. Otherwise looks good. |
datawolf
force-pushed
the
fix-set-rancher.debug-error
branch
from
81f364f
to
fa98165
Compare
when we set rancher.debug to true, the current code also set `-D` flag to system-docker and user-docker daemon. and then we change rancher.debug to false, the `-D` flag is also exist by using command `sudo ros config get rancher.docker`. this patch fix it. Signed-off-by: Wang Long <long.wanglong@huawei.com>
|
@imikushin Sorry for the mistake, the patch have been updated. |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we set rancher.debug to true, the current code also set
-Dflagto system-docker and user-docker daemon.
and then we change rancher.debug to false, the
-Dflag is also existby using command
sudo ros config get rancher.docker.this patch fix it.
Signed-off-by: Wang Long long.wanglong@huawei.com