Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Sign-In #1411

Closed
chillfox opened this issue Jul 7, 2015 · 23 comments
Closed

Google Sign-In #1411

chillfox opened this issue Jul 7, 2015 · 23 comments
Assignees
Labels
area/access-control internal kind/feature Issues that represent larger new pieces of functionality, not enhancements to existing functionality [zube]: Done
Milestone

Comments

@chillfox
Copy link

chillfox commented Jul 7, 2015

Please add support for using google apps accounts for logon.

@deniseschannon deniseschannon added area/accessibility kind/enhancement Issues that improve or augment existing functionality labels Jul 7, 2015
@deniseschannon deniseschannon modified the milestone: Unscheduled Jun 28, 2016
@matt-land
Copy link

So this feature was added? Or just the label was removed?

@vincent99
Copy link
Contributor

release/future label was converted to milestone Unscheduled.

1.2 will include moving auth out of cattle and into a standalone golang project that will be more pluggable. So we could potentially look at this after that, though TBH it seems like there is minimal community interest (and zero customer interest that I'm aware of).

@sjwoodr
Copy link

sjwoodr commented Jun 30, 2016

I would love to have this feature. All of the team has a Google Apps login but not everyone has a GitHub user. Plus, when a developer leaves the company, they retain their GitHub user -- they would not retain access to their Google Apps login.

+1 this feature

@AtomiclyCursed
Copy link

For the same reason as @sjwoodr it would be nice to have, I wouldn't expect permissions to be handed on the Google Apps side, just the oauth and rancher to handle permissions, even if it was just domain locked e.g. @example.com

@johnrengelman
Copy link

Also would be interested in this for customer uses.
Especially now that GitHub is adding SAML integration to their public offering (https://github.com/universe-2016).

This biggest issue here is account deprovisioning as you have to remove someone from the GitHub org which in my experience is something that doesn't quite happen in lock step with some leaving.

@matesitox
Copy link

+1 We have lots of gapps accounts using rancher, makes account managment much easier!

@robbatt
Copy link

robbatt commented Aug 24, 2017

+1 We would also like to see this

@arunkjn
Copy link

arunkjn commented Nov 30, 2017

Hey guys, do you have plans to release this in the near future? We use g apps for our enterprise and would love to see our rancher cluster integrated with it.

@kylegoch
Copy link

@vincent99 any status update on this? Been a few months since an update and was curious.

@vincent99
Copy link
Contributor

Nothing new, we still have no plans to add this without a customer driving it...

@kylegoch
Copy link

Hmm, noted. We are in the process of eval'ing Rancher and noticed it missing. It would make our lives much easier. We may be a customer if we go Rancher. So will definitely request if that happens :-)

@vanhaeren
Copy link

+1 from another potential customer

@loganhz loganhz added version/2.0 kind/feature Issues that represent larger new pieces of functionality, not enhancements to existing functionality and removed kind/enhancement Issues that improve or augment existing functionality labels Oct 2, 2018
@loganhz loganhz removed this from the Unscheduled milestone Oct 18, 2018
@kylegoch
Copy link

Since it's apparently customer driven, is it not possible to just have Universal SAML? We were excited the release notes for 2.1.0 mentioned SAML. However after reading the docs, it's only for Ping Identity and KeyCloak. Which are services I have never heard of before, but some one must be using them enough to warrant the work.

G Suite integration would definitely be an easy win for the community, but understand if you are still abiding by only adding Auth providers for a customer request.

@shmulikah
Copy link

Love to see this feature in a future release.
We have SSO across all of our stack, except Rancher :(
Supporting SAML will be enough

@deniseschannon deniseschannon added this to the v2.3 milestone Apr 9, 2019
@trollr
Copy link

trollr commented Apr 9, 2019

If you want to use GSuite SAML you can use AD FS + https://mattslifebytes.com/2018/08/15/using-okta-and-other-saml-idps-with-rancher-2-0/

@mrajashree
Copy link
Contributor

For Google Oauth #10053

@mrajashree
Copy link
Contributor

Backend for this is ready

@sowmyav27
Copy link
Contributor

Verified this on rancher:master-head

  • Google Auth is enabled.
  • This feature can be enabled/disabled.
  • To enable this, input fields - Admin Email, Domain name, OAuth creds and Service account creds.
  • User is able to enable and disable google auth.
  • On enabling google auth from Rancher UI, user will be redirected to google page and be prompted to enter username and password. User will enter valid details and click on Allow.
  • User gets redirected back to Rancher UI with Google Auth enabled.

@mr-karan
Copy link

@sowmyav27 Testing out the master-head release, is there any doc on what Role to give for the service account? I am getting the following error which I presume is because of wrong permissions:

TestAndApply Error
[Google OAuth] testAndApply: server error while authenticating: Get https://www.googleapis.com/admin/directory/v1/groups?alt=json&domain=redacted.com&prettyPrint=false&userKey=redacted: oauth2: cannot fetch token: 401 Unauthorized Response: { "error": "unauthorized_client", "error_description": "Client is unauthorized to retrieve access tokens using this method, or client not authorized for any of the scopes requested." }

Also, what should be value of Admin email and Domain name in the rancher UI?

Thanks for the PR though! :D

@sowmyav27
Copy link
Contributor

@mr-karan There is an issue related to providing more instructions on the UI for the Service Account creds. #21389

@mrajashree Could you add your comments - as to the exact instructions to set up a Service Account and get the related creds?

@mr-karan
Copy link

@mrajashree Hi! Can you please let me know the instructions to create a SA, would be really helpful! I am stuck on this and would love to go live with the Google Auth 👍

Again, thanks for the PR

@mr-karan
Copy link

mr-karan commented Aug 6, 2019

@sowmyav27 @mrajashree Hi, can I have your attention on this please? :) I upgraded to the latest master release to try this feature, but due to the above mentioned roadblocks, unable to get this rolling. Do you mind documenting the instructions to setup google auth please?

@mrajashree
Copy link
Contributor

@mr-karan The docs aren't up yet but this gist contains the instructions https://gist.github.com/mrajashree/9dc4cd8e11a9e813a96e713964c74ca9

Please let us know if that works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access-control internal kind/feature Issues that represent larger new pieces of functionality, not enhancements to existing functionality [zube]: Done
Projects
None yet
Development

No branches or pull requests