Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old container log symlinks in /var/lib/rancher/rke/log not cleaned up for workers #22549

Closed
superseb opened this issue Aug 30, 2019 · 1 comment

Comments

@superseb
Copy link
Contributor

What kind of request is this (question/bug/enhancement/feature request):
bug

Steps to reproduce (least amount of steps as possible):

  1. Create custom cluster
  2. Add 3 nodes, 1 with etcd, 1 with controlplane, 1 with worker role
  3. Upgrade Kubernetes version of cluster
  4. Wait til provision ends, and wait til worker is finished processing it's new plan.

Result:
New containers are created, symlinks are created for the new containers, but the symlinks to the old containers are still there.

Other details that may be helpful:
In RKE, we have CleanDeadLogs but I can't find anything similar to that in Rancher's way of working with workers. We only have runLogLinker (https://github.com/rancher/rancher/blob/master/pkg/rkeworker/docker.go#L316)

Related (but either with all roles or with non-default Docker root dir):
#16133
#16456

@superseb superseb added the kind/bug Issues that are defects reported by users or that we know have reached a real release label Aug 30, 2019
@zube zube bot removed the [zube]: Backlog label Mar 26, 2020
@superseb superseb removed kind/bug Issues that are defects reported by users or that we know have reached a real release internal labels Jun 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants