Bug: coredns-autoscaler needs readiness and liveness check

[patrick0057]

What kind of request is this (question/bug/enhancement/feature request):
Bug

Steps to reproduce (least amount of steps as possible):
coredns autoscaler does not have a readiness and liveness check

Result:
If a node goes offline where coredns-autoscaler is running, it will not be rescheduled properly.

Other details that may be helpful:

Environment information

• Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
• Installation option (single install/HA): HA

gz#7893
SURE-1649

[rishabhmsra]

Re-opening this issue
Validated this on 2.6-head(6352861), but due to a UI issue cannot validate the Health Check fields.
Logged the ticket rancher/dashboard#5215.

[a-blender]

@rishabhmsra If I understand this correctly, you validated that an RKE1 downstream cluster deploys successfully on 2.6-head(6352861) and the coredns-autoscaler-deployment has the correct health checks, but those checks are not showing up correctly in the UI?

[rishabhmsra]

@annablender, yes I was able to provision the RKE1 downstream cluster on v2.6-head. Also I saw some fields were configured for coredns-autoscaler-deployment healthcheck, but I could not validate it completely because the values were not showing up properly. Also the Liveness Check was not visible at all on the UI. Once the UI issue is fixed, I'll re-validate this.

[snasovich]

Waiting on UI fix rancher/dashboard#5215 which is currently in review.

[a-blender]

@rishabhmsra Sounds great. I'll keep an eye on this.

[snasovich]

The linked rancher/dashboard#5215 is now in test, so moving this one to test too.

[rishabhmsra]

Rancher Server:

• v2.6-head (39befda)
• docker install

Validation steps followed as mentioned here :

• Provisioned a single node AWS node driver k8s v1.22.6-rancher1-2 cluster.
• Checked the coredns-autoscaler heatlh check fields and Readiness and Liveness Check are configured correctly.

Result:

• The Health Check fields values are configured as expected, hence closing the issue.