Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing deployed Rancher Logging looses state if you Edit as File #26559

Closed
Tejeev opened this issue Apr 8, 2020 · 4 comments
Closed

Editing deployed Rancher Logging looses state if you Edit as File #26559

Tejeev opened this issue Apr 8, 2020 · 4 comments
Assignees
Labels
area/logging internal kind/enhancement Issues that improve or augment existing functionality team/ui
Milestone

Comments

@Tejeev
Copy link

Tejeev commented Apr 8, 2020

What kind of request is this (question/bug/enhancement/feature request):
Bug

Steps to reproduce (least amount of steps as possible):

  1. Enable logging on a cluster
  2. Test that all is working.
  3. If it is, go back to logging, and choose to edit as file

Result:
All configurations are lost. The same is true when going the other way.
It is also not at all clear how to format the file or what information should be pulled over.

Expected Behavior
We would expect the input configurations to be retained and displayed as you switch back and forth between the two methods of editing. This would be in line with behavio we see in other items we edit as forms and files throughout the Rancher UI.

Other details that may be helpful:

Environment information

  • Rancher version: v2.3.x

Workaround
If you enabled while editing as form, your configurations are saved in a secret in the correct format.

  1. Go to the system project
  2. Navigate to Secrets
    image
  3. Select rancher-logging-fluentd
    image
  4. Select edit in the top right hand corner elipsis
    image
  5. Search for elastic in your browser and something will be highlighted in the clusters.conf key
    image
    image
  6. If you click in the Value field it will reveal the data. Copy everything in the elasticsearch block. This is the text you must enter into the match tags in the edit as file of your logging deployment
    image

gzrancher/rancher#9427

@Tejeev Tejeev added the internal label Apr 8, 2020
@maggieliu maggieliu added this to the v2.4.4 milestone Apr 20, 2020
@maggieliu maggieliu modified the milestones: v2.4.4, v2.4 - Backlog Apr 20, 2020
@loganhz loganhz changed the title [BUG] Editing deployed Rancher Logging looses state if you Edit as File Editing deployed Rancher Logging looses state if you Edit as File Apr 21, 2020
@loganhz loganhz added the kind/enhancement Issues that improve or augment existing functionality label Apr 21, 2020
@tancou
Copy link

tancou commented May 1, 2020

edit: new issue has been filed for this ticket as it is separate from the main issue
Hi,

I have almost the same issue with the app catalog.
The parser between the View form and the YAML view is not working properly.

Environment information :

Component Version
Rancher v2.4.2
User Interface v2.4.14
Helm v2.16.3-rancher1
Machine v0.15.0-rancher35

Bug 1 :

Steps to reproduce (least amount of steps as possible):

  1. Go to Apps
  2. Deploy an app using YAML
  3. Then upgrade the app.
  4. Use the Form view.

Result:
Fields are empty.

Expected Behavior
Fields should display the correct configuration.

Bug 2 :

Steps to reproduce (least amount of steps as possible):

  1. Go to Apps
  2. Deploy an app using form view
  3. Then upgrade the app.
  4. Show the YAML view

Result:
Boolean values are defined with quotes

myboolean: "true"

The Helm chart can't be upgraded because myboolean is a string and not a boolean.

Expected Behavior

Boolean values should be parsed properly.

myboolean: true

Bug 3 :

Steps to reproduce (least amount of steps as possible):

  1. Go to Apps
  2. Deploy an app using form view
  3. Edit a field/value
  4. Show the YAML view
    (Happens if you edit the YAML first too)

Result:
Values are not updated

Expected Behavior
Values should be the same as form view.

@westlywright
Copy link
Contributor

@tancou thanks for the info. I believe this is a separate issue unrelated to Logging so I have moved into a new ticket (see edit).

@maggieliu maggieliu modified the milestones: v2.4 - Backlog, v2.4.x Jun 23, 2020
@maggieliu maggieliu modified the milestones: v2.4.x, v2.4.7 Jul 26, 2020
@maggieliu maggieliu modified the milestones: v2.4.7, v2.4.8 Sep 1, 2020
@maggieliu maggieliu modified the milestones: v2.4.8, v2.4.9 Sep 2, 2020
@izaac
Copy link
Contributor

izaac commented Oct 19, 2020

Rancher version v2.4-head f210f54
I validated the Fluentd Configuration state is preserved navigating back and forth as Form and as File.

@izaac izaac closed this as completed Oct 19, 2020
@izaac izaac reopened this Oct 19, 2020
@izaac
Copy link
Contributor

izaac commented Oct 19, 2020

Closing this issue as it's specific to v2.4

Will work on #29558 (v2.5) and #29562 (master)

@izaac izaac closed this as completed Oct 19, 2020
@zube zube bot removed the [zube]: Done label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging internal kind/enhancement Issues that improve or augment existing functionality team/ui
Projects
None yet
Development

No branches or pull requests

8 participants