CRDs not available to helm template when installing with Helm 3

[brendarearden]

What kind of request is this (question/bug/enhancement/feature request):
bug

Steps to reproduce (least amount of steps as possible):
Add a catalog with URL https://github.com/PennyScissors/ohmyglb
Set the catalog helm version to helm 3
Attempt to install the ohmyglb app from the newly added catalog

Result:
Wait helm template rendering notes failed. manifest_sorter.go:192: info: skipping unknown hook: "crd-install" Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "EtcdCluster" in version "etcd.database.coreos.com/v1beta2" : exit status 1

Other details that may be helpful:

rancher/pkg/controllers/user/helm/common.go

Line 156 in 01a8242

commands = append([]string{"template", obj.Name, appDir, "--namespace", obj.Spec.TargetNamespace, "--kubeconfig", tempDir.KubeConfigInJail}, setValues...)

The template command for helm 3 does not currently use the --include-crds flag that was added as part of helm/helm#7138 so the template is not able to render properly which results in an error being thrown

Environment information

• Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
• Installation option (single install/HA):
  Rancher v2.4.2 single install

[rancher-max]

Reopening because still seeing the same issue following the same steps on both v2.4-head and master-head

[brendarearden]

rancher/pkg/controllers/user/helm/common.go

Line 180 in dd102af

commands = append([]string{"upgrade", "--install", obj.Name, appDir, "--dry-run", "--namespace", obj.Spec.TargetNamespace, "--kubeconfig", tempDir.KubeConfigInJail}, setValues...)

<< line that is causing error. --dry-run flag does not allow crds to be included. Using helm install --dry-run was a work around since helm 3 does not support helm template --notes for rendering notes.

[rancher-max]

Validated in v2.4-head and master-head

• This chart is able to be deployed using helm3 and the error does not occur

• Notes are working properly when this app is deployed
• App deploys successfully using non-default options and when setting custom answers

[dnoland1]

Hit this issue about 30 minutes ago and have also noticed this causes significant spikes in CPU and load on the node running Rancher: