[2.4] Refactor render notes to use get notes #27228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhhc
pushed a commit
to uhhc/rancher
that referenced
this pull request
Sep 29, 2020
…-render-notes [2.4] Refactor render notes to use get notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
Problem
App install is failing when trying to install app that has CRDs with helm 3 as the command being used to generate the notes does not support CRDs to be rendered
Solution
Change notes logic to use helm get notes after install is completed.
Additional Info
If install fails, the app revision available will have empty notes. This was not the behavior previously
Issue
#26999