Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio chart should set minimum cpu/memory request #30144

Closed
cbron opened this issue Nov 18, 2020 · 4 comments
Closed

Istio chart should set minimum cpu/memory request #30144

cbron opened this issue Nov 18, 2020 · 4 comments
Assignees
Milestone

Comments

@cbron
Copy link
Contributor

cbron commented Nov 18, 2020

The v1 istio chart has a minimum cpu and memory requirement for the cluster. V2 should do this also with chart annotations, see the helm chart reqs doc. We can use the most common istio installation as the case.

@cbron
Copy link
Contributor Author

cbron commented Jan 5, 2021

Parent mem/cpu issue: rancher/dashboard#1849

@Ellenqs
Copy link

Ellenqs commented Feb 9, 2021

This is validated on Rancher v2.5-head (df89971).
Istio version: v1.8.100-rc01

Steps

  • Deploy rancher single install.
  • Create a downstream cluster (1 control plane, 1 etcd, 3 worker).
  • Go to cluster explorer, install monitoring, then install istio.
  • Go to App & Marketplace, find rancher-istio in Installed Apps, click view YAML, check chart annotations in the file.

Result:
Istio is installed successfully and the cpu and memory requests are shown in annotation.

Screen Shot 2021-02-08 at 2 41 22 PM

@cbron
Copy link
Contributor Author

cbron commented Feb 9, 2021

@Ellenqs is there a warning when you don't have enough resources ? Or is that not built yet.

@bmdepesa
Copy link
Member

bmdepesa commented Feb 9, 2021

@cbron that's covered in this issue (see the linked comment): rancher/dashboard#1849 (comment) which is in Next Up. We'll test that part of the functionality with that issue.

@zube zube bot removed the [zube]: Done label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants