Joining node to cluster fails on windows with docker 19.03.13

[ranchersvet]

Try to join windows node with docker 19.03.13 running to a rancher created cluster. It fails.

- [ PS C:\Users\Administrator> PowerShell -NoLogo -NonInteractive -Command "& {docker run -v c:/:c:/host rancher/rancher-agent:v2.4.5 bootstrap --server https://r.thecoffee.dev --token 6fph62jld8kc6sh9x6fpbgrz7tckwcgb774z8srqkt698jwr9f65px --worker | iex}"
INFO: Detecting running permission ...
INFO: Detecting host CPU reservation ...
INFO: Detecting host RAM reservation ...
INFO: Detecting host DISK reservation ...
INFO: Detecting host Docker name pipe existing ...
INFO: Detecting host Docker release version ...
FATA: Only support with Docker EE
The error seems to be:
 $dockerPlatform = docker.exe version -f "{{.Server.Platform.Name}}"
PS C:\Users\Administrator> $dockerPlatform = docker.exe version -f "{{.Server.Platform.Name}}"
PS C:\Users\Administrator> $dockerPlatform
Mirantis Container Runtime
```] 

If you run it on docker 19.03.12 it returns


Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.PS C:\Users\administrator.SB> $dockerPlatform = docker.exe version -f "{{.Server.Platform.Name}}"
PS C:\Users\administrator.SB> $dockerPlatform

Docker Engine - Enterprise (this node is not a swarm manager - check license status on a manager node)

That is the raw JSON dump from 19.03.12:

PS C:\Users\administrator.SB>

PS C:\Users\Administrator> docker version --format '{{json .}}'
{"Client":{"Platform":{"Name":"Mirantis Container Runtime"},"Version":"19.03.13","ApiVersion":"1.40","DefaultAPIVersion":"1.40","GitCommit":"0c38b2d","GoVersion":"go1.13.15","Os":"windows","Arch":"amd64","BuildTime":"11/12/2020 21:33:08","Experimental":false},"Server":{"Platform":{"Name":"Mirantis Container Runtime"},"Components":[{"Name":"Engine","Version":"19.03.13","Details":{"ApiVersion":"1.40","Arch":"amd64","BuildTime":"11/12/2020 21:31:44","Experimental":"false","GitCommit":"5b5efb2d49","GoVersion":"go1.13.15","KernelVersion":"10.0 17763 (17763.1.amd64fre.rs5_release.180914-1434)","MinAPIVersion":"1.24","Os":"windows"}}],"Version":"19.03.13","ApiVersion":"1.40","MinAPIVersion":"1.24","GitCommit":"5b5efb2d49","GoVersion":"go1.13.15","Os":"windows","Arch":"amd64","KernelVersion":"10.0 17763 (17763.1.amd64fre.rs5_release.180914-1434)","BuildTime":"11/12/2020 21:31:44"}}

gz#13534

gz#13540

[sowmyav27]

Reproduced the issue on 2.4.8

• Deploy a windows cluster - VXLAN, 1 linux all roles nodes, 1 windows node (docker 19.03.13 version).
• Run agent command on windows node.
• Fails:

INFO: Detecting running permission ...
INFO: Detecting host CPU reservation ...
INFO: Detecting host RAM reservation ...
INFO: Detecting host DISK reservation ...
INFO: Detecting host Docker name pipe existing ...
INFO: Detecting host Docker release version ...
FATA: Only support with Docker EE

• Docker version on windows:

docker version
Client: Mirantis Container Runtime
 Version:           19.03.13
 API version:       1.40
 Go version:        go1.13.15
 Git commit:        0c38b2d
 Built:             11/12/2020 21:33:08
 OS/Arch:           windows/amd64
 Experimental:      false

Server: Mirantis Container Runtime
 Engine:
  Version:          19.03.13
  API version:      1.40 (minimum version 1.24)
  Go version:       go1.13.15
  Git commit:       5b5efb2d49
  Built:            11/12/2020 21:31:44
  OS/Arch:          windows/amd64
  Experimental:     false

On 2.4-head-commit id: 463d77a26

• Able to deploy a windows cluster with windows nodes having docker 19.03.13 version
• 1 all roles linux and 2 windows worker nodes
• Workload deployment and ingress works

Verified able to register 19.03.12 docker version windows nodes also.

[sowmyav27]

Reopening for a fix in 2.5 and master branches

[maggieliu]

There is a 2.5 forward port issue already. We can close this after test in 2.4.11: #30159

[sowmyav27]

Closing this as we have a separate forward port issue.