Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logging v2] Provide option to only collect Linux node logs on Windows Clusters #32264

Closed
nickgerace opened this issue Apr 21, 2021 · 5 comments
Closed

[Logging v2] Provide option to only collect Linux node logs on Windows Clusters #32264

nickgerace opened this issue Apr 21, 2021 · 5 comments
Assignees
@izaac @nickgerace
Labels
area/logging kind/bug-qa Issues that have not yet hit a real release. Bugs introduced by a new feature or enhancement kind/enhancement Issues that improve or augment existing functionality
Milestone
v2.5.8

Comments

@nickgerace
Copy link
Contributor

nickgerace commented Apr 21, 2021 •
edited

Since global.cattle.windows.enabled is an immutable field set by the dashboard, we need another field for enabling/disabling Windows log collection, or we need to evaluate using nil flags.
@nickgerace nickgerace self-assigned this Apr 21, 2021
@nickgerace nickgerace added this to the v2.5.8 milestone Apr 21, 2021
@nickgerace
Copy link
Contributor Author

Opened as a result of: rancher/dashboard#2684 (comment)

@izaac izaac mentioned this issue Apr 21, 2021
Closed
@nickgerace nickgerace mentioned this issue Apr 21, 2021
Merged
@sowmyav27 sowmyav27 added [zube]: QA Next up kind/bug-qa Issues that have not yet hit a real release. Bugs introduced by a new feature or enhancement and removed [zube]: To Test labels Apr 22, 2021
@izaac
Copy link
Contributor

izaac commented Apr 23, 2021 •
edited

Rancher version: v2.5.8-rc9
Logging chart version: 3.9.400 (no RC is shown)

Scenario Default

The option is working now, the default if the key doesn't exist is global.cattle.windows.enabled = true
nodeagent daemonsets are deployed as expected.

Scenario to False

Setting global.cattle.windows.enabled = false, is preserved after chart install.
nodeagent daemonsets are NOT deployed as expected.

Scenario Upgrade from True to False (Failed)

The node agents are still present after upgrading global.cattle.windows.enabled from true to false.

The commented documentation in values.yaml is removed from the Rancher UI Values YAML view, we need to make sure is included in the doc issue.

https://github.com/rancher/docs/issues/3141

@zube zube bot removed the [zube]: QA Working label Apr 23, 2021
@izaac izaac mentioned this issue Apr 23, 2021
Closed
@nickgerace nickgerace mentioned this issue Apr 23, 2021
Merged
@nickgerace
Copy link
Contributor Author

Scenario Upgrade from True to False (Failed)

The node agents are still present after upgrading global.cattle.windows.enabled from true to false.

@izaac: confirmed that this is an upstream issue after investigation with @aiyengar2 @paynejacob. Reproduction steps have been filed in the upstream issue: kube-logging/logging-operator#725

@nickgerace
Copy link
Contributor Author

nickgerace commented Apr 23, 2021 •
edited

Moving this to To Test for the following scenarios:

  • Install with default values
  • Install, global.cattle.windows.enabled set to true
  • Install, global.cattle.windows.enabled set to false

Creating a new issue (https://github.com/rancher/rancher/issues/32325) to track the following scenario:

  • Upgrade, global.cattle.windows.enabled changed to false when already to true

@izaac
Copy link
Contributor

izaac commented Apr 24, 2021

Rancher version: v2.5.8-rc9
Logging Chart version: 3.9.400 (latest build as this is not showing the RC anymore in 2.5)

The following scenarios worked as expected.

  • Install with default values
  • Install, global.cattle.windows.enabled set to true
  • Install, global.cattle.windows.enabled set to false

@izaac izaac closed this as completed Apr 24, 2021
@shpwrck shpwrck added the kind/enhancement Issues that improve or augment existing functionality label May 4, 2021
@nickgerace nickgerace mentioned this issue May 11, 2021
Open
@zube zube bot removed the [zube]: Done label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@izaac izaac

@nickgerace nickgerace

Labels
area/logging kind/bug-qa Issues that have not yet hit a real release. Bugs introduced by a new feature or enhancement kind/enhancement Issues that improve or augment existing functionality
Projects
None yet
Milestone
v2.5.8
Development

No branches or pull requests
4 participants
@izaac @sowmyav27 @nickgerace @shpwrck