Add option to disable Windows logging for Windows clusters #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgerace
requested review from
paynejacob,
jiaqiluo and
aiyengar2
and removed request for
jiaqiluo
paynejacob
previously approved these changes
Apr 21, 2021
nickgerace
commented
Apr 21, 2021
packages/rancher-logging/generated-changes/patch/values.yaml.patch
Outdated
Show resolved
Hide resolved
aiyengar2
requested changes
Apr 21, 2021
There was a problem hiding this comment.
Based on conversation with @vincent99 offline, I think we should not introduce a brand new field but rather comment out global.cattle.windows.enabled in the values.yaml for this chart and introduce a slight change to the way we check whether it is enabled to allow it to be unset in the values.yaml.
See my comment in this review.
packages/rancher-logging/generated-changes/overlay/templates/loggings/root/logging.yaml
Outdated
Show resolved
Hide resolved
nickgerace
force-pushed
the
dev-v2.5-source-windows
branch
from
519ece2
to
bde0e1d
Compare
|
Entirely agree with @aiyengar2's idea from the offline discussion. PR will now reflect that. |
nickgerace
force-pushed
the
dev-v2.5-source-windows
branch
from
bde0e1d
to
6b449a5
Compare
aiyengar2
requested changes
Apr 22, 2021
nickgerace
force-pushed
the
dev-v2.5-source-windows
branch
from
6b449a5
to
67dec49
Compare
paynejacob
previously approved these changes
Apr 22, 2021
cbron
reviewed
Apr 22, 2021
nickgerace
dismissed stale reviews from cbron, paynejacob, and aiyengar2
via
93798b2
nickgerace
force-pushed
the
dev-v2.5-source-windows
branch
from
67dec49
to
93798b2
Compare
paynejacob
approved these changes
Apr 22, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Add option to disable Windows logging for Windows clusters
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Add option to disable Windows logging for Windows clusters
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Merge pull request #1133 from nickgerace/dev-v2.5-source-windows Add option to disable Windows logging for Windows clusters
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Merge pull request #1133 from nickgerace/dev-v2.5-source-windows Add option to disable Windows logging for Windows clusters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues: