vSphere CPI/CSI options omitted when selecting vsphere cloud provider in Rancher 2.6.7 or newer

[David-VTUK]

Setup

• Rancher version: >= 2.6.7
• Browser type & version: Firefox 104.0

Describe the bug
vSphere CSI options are omitted when selecting the respective cloud provider in rke2 provisioning. vSphere CPI options however remain

To Reproduce
Create cluster -> RKE2 -> Select vSphere as the cloud provider > Navigate to addon config

Result

Expected Result
vSphere CPI options presented, vSphere CSI options are omitted.

Screenshots
In 2.6.7/2.6.8:

in 2.6.6

Additional context

In 2.6.6 the latest (non experimental) version of RKE2 is 1.22.13
In 2.6.8 the latest version of RKE2 is 1.24.4

The CSI chart has a version restriction:

https://github.com/rancher/charts/blob/36de515042fb94888c751aeedd645f6ffae6a854/index.yaml#L8784

  rancher-vsphere-csi:
  - annotations:
      catalog.cattle.io/certified: rancher
      catalog.cattle.io/display-name: vSphere CSI
      catalog.cattle.io/kube-version: '>= 1.20.0-0 < 1.24.0-0'

Even in 2.6.8, if a valid version is specified for the RKE2 version, the CSI options are not present.

The CPI chart does have a version restriction, but is higher:

https://github.com/rancher/charts/blob/36de515042fb94888c751aeedd645f6ffae6a854/index.yaml#L8576

  rancher-vsphere-cpi:
  - annotations:
      catalog.cattle.io/certified: rancher
      catalog.cattle.io/display-name: vSphere CPI
      catalog.cattle.io/kube-version: '>= 1.18.0-0 < 1.25.0-0'

What I suspect is happening:

• in 2.6.8 when an RKE2 version is created, it defaults to the latest version (1.24.4) which is outside the range of the CSI chart but not the CPI chart. However, if you were to select a different version that does fall within this range, this is not re-evaluated.

• in 2.6.6 when an RKE2 cluster is created, it defaults to the latest version (1.22.13) which is inside the range of both charts, therefore both chart values are seen

Therefore, I believe an action needs to be performed in the UI whenever a specific k8s version is selected to re-evaluate respective addon charts for the vSphere cloud provider, assuming the version restriction is for a legitimate reason.

[codyrancher]

I was able to reproduce this in 2.6.8-patch1. It appears that the reason the CSI fields are missing appears to be because it's missing from the backend rancher-rke2-charts response. The frontend doesn't pass the k8s version or anything so I don't think the version field is relevant here.

In the latest 2.6-head you can see the response includes csi.

If we want a root cause I think we'll need to have the backend chime in but since this is already fixed in the latest I'm going to move this to test.

[jameson-mcghee]

I was able to reproduce this issue on v2.6.7 by following the steps to reproduce. However, on v2.6-head (Commit ID: 45bbbbf), the issue had been resolved and I was again able to observe the vSphere CSI Configuration form in the UI. Therefore I am closing this ticket.

Repro Steps:

• Spin up a Rancher server inside of vSphere
• Navigate to the Cluster Management --> Cloud Credentials page, and click the Create button
• Select the VMware vSphere option
• Input a unique name as well as valid vCenter, Port, Username, and Password information, and then click the Create button
• Toggle for RKE2/K3s, and then select the VMware vSphere Node Driver cluster option
• In the Cluster Configuration --> Basics section, set Cloud Provider to vSphere
• Click the Add-On Config link

• Note that the vSphere CSI Configuration form is not present in the Cluster Configuration --> Add-On Config section (on v2.6.7)

v2.6.7:

v2.6-head (Commit ID: 45bbbbf):

[David-VTUK]

I recently upgraded to 2.6.9 (official release) and can reproduce this issue - requesting we reopen this.

[vivek-shilimkar]

I re-tested this behaviour on rancher v2.6.9 and v2.7.0 for RKE2 type cluster (v1.24.8+rke2r1).

On rancher v2.6.9 both the CPI and CSI options are not visible.

On rancher v2.7.0 CPI option is not visible but the CSI option is visible as mentioned here by @slickwarren

[vivek-shilimkar]

On rancher v2.6.9 for k8s cluster v1.23.14+rke2r1 only CSI configuration is visible.

[vivek-shilimkar]

On rancher v2.6.9 for k8s cluster v1.22.16+rke2r1 only CPI configuration is visible along with Calico configuration.

[vardhaman22]

/backport 2023-Q1-v2.6x

[vivek-shilimkar]

Tested the CSI/CPI cloud configuration visibility on rancher v2.7.0 while pointing KDM to Dev branch.