Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hull testing to OPA Gatekeeper charts #41026

Closed
MKlimuszka opened this issue Mar 31, 2023 · 6 comments
Closed

Add Hull testing to OPA Gatekeeper charts #41026

MKlimuszka opened this issue Mar 31, 2023 · 6 comments

Comments

@MKlimuszka
Copy link
Collaborator

No description provided.

@doflamingo721
Copy link
Contributor

doflamingo721 commented Jul 24, 2023

The hull testing coverage 100% coverage for the gatekeeper chart is not possible at the moment because of multiple issues in the upstream and rancher's gatekeeper template. Some of the issues are already logged (#41688 and #41689) but similar indentation and tolerations from values.yaml not getting applied to the templates issues still persist in other templates as well. Some fixes are already raised in the upstream chart for this (open-policy-agent/gatekeeper#2817 and open-policy-agent/gatekeeper#2862) but these fixes would be released with the new gatekeeper chart. As of now the chart coverage is at 97 percent.
I'd suggest merging the PR at 97 percent coverage and with coverage disabled so that it won't affect the ci builds.
Edit: The PR cannot be merged since it has a failure which will cause every ci build to fail if we merge this PR as it is.
@eliyamlevy @gunamata What do you think should be the right approach?

@Jono-SUSE-Rancher
Copy link
Contributor

@MKlimuszka - We cant keep this in v2.7.7. If we're blocked by upstream (or blocked by the CI build failures. Can we determine what the course of action here is and remove it from v2.7.7?
cc @doflamingo721

@mitulshah-suse
Copy link

@gunamata @diogoasouza Can you please advise about the below. As we had discussed earlier, this cannot be pushed in yet, due to upstream fixes pending and the handover for these have already been given to your team. So i believe your team will need to take this further.
cc: @Jono-SUSE-Rancher

@gunamata
Copy link

gunamata commented Oct 6, 2023

@mitulshah-suse , the indentation issue (#41689) has been resolved but we did not yet get a chance to work on #41688 . We will add this to our list of Q1 items. Removing the milestone 2.7.7 and put it under 2024-v2.8x-Backlog

@mitulshah-suse
Copy link

@gunamata Ok, we are unassigning ourselves from this issue as well, since your team will be working on it once upstream issues are fixed.

Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants