Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: security context value indentation for gatekeeper-delete-webhook-configs job #2862

Conversation

vardhaman-surana
Copy link
Contributor

@vardhaman-surana vardhaman-surana commented Jul 6, 2023

What this PR does / why we need it:
This PR fixes the indentation issue found here.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2861

Special notes for your reviewer:

…configs job

Signed-off-by: Vardhaman Surana <maans406@gmail.com>
@vardhaman-surana vardhaman-surana changed the title fix security context value indentation for gatekeeper-delete-webhook-configs job fix: security context value indentation for gatekeeper-delete-webhook-configs job Jul 6, 2023
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR!

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (6c38e80) 53.59% compared to head (ff13b9b) 53.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2862      +/-   ##
==========================================
+ Coverage   53.59%   53.63%   +0.03%     
==========================================
  Files         133      133              
  Lines       11545    11545              
==========================================
+ Hits         6188     6192       +4     
+ Misses       4881     4878       -3     
+ Partials      476      475       -1     
Flag Coverage Δ
unittests 53.63% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ritazh ritazh merged commit c6eb32a into open-policy-agent:master Jul 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indentation error in gatekeeper helm chart v3.12.0 in gatekeeper-delete-webhook-configs job
4 participants