Backport performance improvements #19442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased size of parent cache to 100k from 1k. Prior, when retrieving a large number of resources (over 1k) items would shift out of the cache before being called again. This caused misses on most requests. Now, size of cache has increased 10x and misses have been largely reduced. Using non-expiration lru cache, as the data is static and does not need to be discarded after a set time.
Test script now runs go tests. Disabled existing test setup in e2e package, as the the necessary dependencies for it appear to be missing. This reverts commit 3bb7a2778d186daaf61fc1ec8f28959ad8616dad.
Manual backport of commit f2b601c from master. Norman now has a recognized option for opting out of pagination. Prior, passing a limit of -1 would set the pagination limit to the default, 1000. The backend would serve a paginated response that the UI automatically aggregates. This led multiple api calls, each of which taking as long to return as a single non-paginated result. Now, one non-paginated response will be returned when limit is -1.
Backport of d040b64 from master Norman now tracks and assigns project namespaces which are necessary to filter project requests.
Now, identifies and supplies namespaces to namespace filter for requests associated with given project. Prior, the backend listed items belonging to all namespaces in all projects no matter what, and then filtered. This led to longer request times for projects that contained a fraction of total resources. Now, request times are improved and largely dependent on resource amount for the given project.
Added tests for logic in project setter store.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports several API performance improvements from master to
v2.2. It also pulls in a commit that causes us to run
go testas partof CI builds.
#19443